chore(codebase): full cleanup pass

backend/Modules/Memberships/Handlers/CancelMembership.cs

@@ -19,18 +19,18 @@ public class CancelMembershipHandler(
         Delete("/api/memberships");
         Options(o => o.WithTags("Memberships"));
     }
-    
+
     public override async Task HandleAsync(
         CancelMembershipRequest req,
         CancellationToken ct)
     {
-        var subscription = await dbContext
+        Membership? subscription = await dbContext
             .Memberships
             .FindAsync(
                 [req.SubscriptionId],
-                cancellationToken: ct);
+                ct);
 
-        if (subscription is not { EndDate: null } 
+        if (subscription is not { EndDate: null }
             || subscription.StripeSubscriptionId is null)
         {
             await SendNotFoundAsync(ct);

backend/Modules/Memberships/Handlers/CreateMembershipTier.cs

@@ -27,9 +27,9 @@ public class CreateMembershipTierEndpoint(
         CreateMembershipTierRequest req,
         CancellationToken ct)
     {
-        var tierId = Guid.CreateVersion7();
+        Guid tierId = Guid.CreateVersion7();
 
-        var productId = await membershipTierProcessor.CreateAsync(
+        string productId = await membershipTierProcessor.CreateAsync(
             req.CreatorId,
             tierId,
             req.Name,
@@ -37,14 +37,14 @@ public class CreateMembershipTierEndpoint(
             req.Price);
 
         // Record the new Tier
-        var tier = new MembershipTier
+        MembershipTier tier = new()
         {
             Id = tierId,
             CreatorId = req.CreatorId,
             Price = req.Price,
             Name = req.Name,
             Description = req.Description,
-            StripeProductId = productId,
+            StripeProductId = productId
         };
 
         dbContext.MembershipTiers.Add(tier);

backend/Modules/Memberships/Handlers/GetActiveMemberships.cs

@@ -28,16 +28,16 @@ public class GetActiveMembershipsHandler(
     public override async Task HandleAsync(
         CancellationToken ct)
     {
-        var subscriptions = await dbContext
+        List<Membership> subscriptions = await dbContext
             .Memberships
             .Where(subscription => subscription.UserId == User.GetUserId())
             .Where(subscription => subscription.State == MembershipState.Active)
             .ToListAsync(ct);
 
-        var result = await Task.WhenAll(
+        GetActiveMembershipsResponse[] result = await Task.WhenAll(
             subscriptions.Select(async subscription =>
             {
-                var creator = await creatorLookup.GetCreatorAsync(subscription.CreatorId, ct);
+                CreatorReference? creator = await creatorLookup.GetCreatorAsync(subscription.CreatorId, ct);
 
                 return new GetActiveMembershipsResponse(
                     subscription.Id,

backend/Modules/Memberships/Handlers/GetMembershipTiers.cs

@@ -4,7 +4,7 @@ namespace Hutopy.Modules.Memberships.Handlers;
 
 [PublicAPI]
 public record GetMembershipTiersRequest
-{ 
+{
     public Guid CreatorId { get; set; }
 }
 
@@ -34,7 +34,7 @@ public class GetMembershipTiersEndpoint(
         GetMembershipTiersRequest req,
         CancellationToken ct)
     {
-        var tiers = await dbContext
+        List<TierModel> tiers = await dbContext
             .MembershipTiers
             .Where(tier => tier.CreatorId == req.CreatorId)
             .Select(tier => new TierModel(

backend/Modules/Memberships/Handlers/SubscribeToCreator.cs

@@ -44,7 +44,7 @@ public class SubscribeHandler(
         SubscribeRequest req,
         CancellationToken ct)
     {
-        var tier = await dbContext
+        MembershipTier? tier = await dbContext
             .MembershipTiers
             .Where(tier => tier.Id == req.MembershipTierId)
             .FirstOrDefaultAsync(ct);
@@ -54,7 +54,7 @@ public class SubscribeHandler(
             return;
         }
 
-        var creator = await creatorLookup.GetCreatorAsync(tier.CreatorId, ct);
+        CreatorReference? creator = await creatorLookup.GetCreatorAsync(tier.CreatorId, ct);
         if (creator == null)
         {
             await SendNotFoundAsync(ct);
@@ -68,7 +68,7 @@ public class SubscribeHandler(
         }
 
         // Process Stripe subscription
-        var checkoutSession = await membershipPaymentProcessor.CreateCheckoutSessionAsync(
+        MembershipCheckoutSession checkoutSession = await membershipPaymentProcessor.CreateCheckoutSessionAsync(
             User.GetUserId(),
             creator,
             tier.Id,
@@ -78,6 +78,6 @@ public class SubscribeHandler(
 
         await SendOkAsync(
             new SubscriptionResponse { StripeCheckoutUrl = checkoutSession.Url },
-            cancellation: ct);
+            ct);
     }
 }