chore(codebase): full cleanup pass

backend/Modules/Messaging/Data/MessagingDbContext.cs

@@ -10,6 +10,8 @@ public class MessagingDbContext(
 {
     public const string SchemaName = "Messaging";
 
+    public DbSet<Message> Messages { get; set; }
+
     protected override void OnModelCreating(ModelBuilder modelBuilder)
     {
         modelBuilder.HasDefaultSchema(SchemaName);
@@ -21,8 +23,6 @@ public class MessagingDbContext(
             .HasDefaultValueSql("CURRENT_TIMESTAMP");
     }
 
-    public DbSet<Message> Messages { get; set; }
-
     public async Task<IEnumerable<MessageDto>> GetMessagesAsync(
         Guid subjectId,
         Guid? parentId,
@@ -30,7 +30,7 @@ public class MessagingDbContext(
         int pageSize,
         CancellationToken ct = default)
     {
-        var query = Messages
+        IQueryable<Message> query = Messages
             .Where(c => c.SubjectId == subjectId)
             .Where(c => c.ParentId == parentId);
 
@@ -39,7 +39,7 @@ public class MessagingDbContext(
             var lastMessage = await Messages
                 .Where(c => c.Id == lastId.Value)
                 .Select(c => new { c.CreatedAt, c.Id })
-                .FirstOrDefaultAsync(cancellationToken: ct);
+                .FirstOrDefaultAsync(ct);
 
             if (lastMessage != null)
             {
@@ -49,17 +49,17 @@ public class MessagingDbContext(
             }
         }
 
-        var messages = await query
+        List<Message> messages = await query
             .OrderByDescending(c => c.CreatedAt)
             .ThenByDescending(c => c.Id)
             .Take(pageSize)
-            .ToListAsync(cancellationToken: ct);
+            .ToListAsync(ct);
 
 
-        var result = await Task.WhenAll(
+        MessageDto[] result = await Task.WhenAll(
             messages.Select(async message =>
             {
-                var writer = await userLookup.GetUserAsync(message.CreatedBy, ct);
+                UserReference? writer = await userLookup.GetUserAsync(message.CreatedBy, ct);
                 return new MessageDto(
                     message.Id,
                     message.SubjectId,
@@ -80,11 +80,11 @@ public class MessagingDbContext(
         int pageSize,
         CancellationToken ct = default)
     {
-        var query = Messages
+        IQueryable<Message> query = Messages
             .Where(c => c.SubjectId == subjectId)
             .Where(c => c.ParentId == parentId);
 
-        var messageCount = await query
+        int messageCount = await query
             .Take(pageSize)
             .CountAsync(ct);