From 9ff8af7a25b678b8121b42e4efbb9baa266e1600 Mon Sep 17 00:00:00 2001
From: Jonathan Bourdon <lowrad000@gmail.com>
Date: Wed, 16 Apr 2025 18:14:39 -0400
Subject: [PATCH] Fix race condition in NameEditor

---
 frontend/src/views/creators/NameEditor.vue | 85 +++++++++++++++++-----
 1 file changed, 67 insertions(+), 18 deletions(-)

diff --git a/frontend/src/views/creators/NameEditor.vue b/frontend/src/views/creators/NameEditor.vue
index 9bf5fb9..ee6dc30 100644
--- a/frontend/src/views/creators/NameEditor.vue
+++ b/frontend/src/views/creators/NameEditor.vue
@@ -1,5 +1,5 @@
 <script setup>
-import {computed, ref} from "vue";
+import {ref, onMounted, onUnmounted} from "vue";
 import {v7} from "uuid";
 import {useClient} from "@/plugins/api.js";
 
@@ -18,44 +18,93 @@ const emits = defineEmits([
 ]);
 
 const name = ref(props.name);
-const isReserved = computed(() => reservationState.value === 'reserved');
 
 const isOperationPending = ref(false);
 const reservationState = ref(null);
-const reservationId = ref(v7());
 
+// Use the reservationId from props if provided, otherwise generate a new one
+const reservationId = ref(props.creatorNameReservationId || v7());
+
+// Ensure we emit the reservationId on mount if we generated a new one
+onMounted(() => {
+  if (!props.creatorNameReservationId) {
+    emits('update:creatorNameReservationId', reservationId.value);
+  }
+});
+
+// Request handling
+let currentController = null;
 let timeout = null;
-const handleInput = () => {
-  clearTimeout(timeout);
-  timeout = setTimeout(() =>
-          checkNameAvailability(),
-      200);
+let lastProcessedName = '';
+
+const cancelCurrentRequest = () => {
+  if (currentController) {
+    currentController.abort();
+    currentController = null;
+  }
 };
 
-const client = useClient()
-const checkNameAvailability = async () => {
-  if (!name.value || name.value.trim() === "") {
+const handleInput = () => {
+  clearTimeout(timeout);
+  timeout = setTimeout(() => {
+    const currentName = name.value;
+    if (currentName === lastProcessedName) {
+      return; // Skip if we've already processed this exact name
+    }
+    checkNameAvailability(currentName);
+  }, 200);
+};
+
+const client = useClient();
+const checkNameAvailability = async (nameToCheck) => {
+  if (!nameToCheck || nameToCheck.trim() === "") {
     reservationState.value = null;
+    lastProcessedName = nameToCheck;
     return;
   }
 
+  // Cancel any ongoing request
+  cancelCurrentRequest();
+
   try {
     isOperationPending.value = true;
     reservationState.value = "loading";
+
+    // Create a new request with cancellation token
+    const controller = new AbortController();
+    currentController = controller;
+
     await client.post(
-        `/api/creators/@${encodeURIComponent(name.value)}/reserve`,
-        {reservationId: reservationId.value}
+      `/api/creators/@${encodeURIComponent(nameToCheck)}/reserve`,
+      { reservationId: reservationId.value },
+      { signal: controller.signal }
     );
-    reservationState.value = "reserved";
+
+    // Only process the response if this is still the current request
+    if (currentController === controller) {
+      reservationState.value = "reserved";
+      lastProcessedName = nameToCheck;
+      emits('update:name', nameToCheck);
+    }
   } catch (error) {
-    reservationState.value = "unavailable"; // Handle API failure case
+    // Only process the error if this is still the current request and it's not an abort error
+    if (currentController && error.name !== 'AbortError') {
+      reservationState.value = "unavailable";
+      lastProcessedName = nameToCheck;
+    }
   } finally {
-    emits('update:name', name.value);
-    emits('update:creatorNameReservationId', reservationId.value);
-    isOperationPending.value = false;
+    if (currentController) {
+      isOperationPending.value = false;
+    }
   }
 };
 
+// Cleanup on component unmount
+onUnmounted(() => {
+  cancelCurrentRequest();
+  clearTimeout(timeout);
+});
+
 </script>
 
 <template>