refactor(auth): cleanup auth module and streamline the registration flow

backend/Modules/Identity/Handlers/Register.cs

@@ -1,7 +1,6 @@
-using Hutopy.Infrastructure.Security;
-using Hutopy.Modules.Identity.Configuration;
 using Hutopy.Modules.Identity.Data;
-using Microsoft.Extensions.Options;
+using Hutopy.Modules.Identity.Services;
+using Microsoft.AspNetCore.Identity;
 
 namespace Hutopy.Modules.Identity.Handlers;
 
@@ -13,13 +12,12 @@ public record RegisterRequest(
 
 [PublicAPI]
 public record RegisterResponse(
-    string AccessToken,
-    string RefreshToken);
+    string Message);
 
 [PublicAPI]
 public class RegisterHandler(
     UserManager userManager,
-    IOptionsSnapshot<JwtOptions> jwtOptions)
+    EmailVerificationService emailVerificationService)
     : Endpoint<RegisterRequest, RegisterResponse>
 {
     public override void Configure()
@@ -34,7 +32,7 @@ public class RegisterHandler(
         CancellationToken ct)
     {
         // Check if the user already exists
-        var existingUser = await userManager.FindByEmailAsync(request.Email);
+        User? existingUser = await userManager.FindByEmailAsync(request.Email);
         if (existingUser is not null)
         {
             await SendStringAsync(
@@ -44,27 +42,22 @@ public class RegisterHandler(
             return;
         }
 
-        // Create a refresh token
-        var refreshToken = RefreshTokenGenerator.Next();
-        
         // Split the name into firstname and lastname (if provided)
-        var nameParts = request.Name.Split(' ', 2);
-        var firstname = nameParts[0];
-        var lastname = nameParts.Length > 1 ? nameParts[1] : string.Empty;
+        string[] nameParts = request.Name.Split(' ', 2);
+        string firstname = nameParts[0];
+        string lastname = nameParts.Length > 1 ? nameParts[1] : string.Empty;
 
         // Create a new user
-        var user = new User
+        User user = new()
         {
             UserName = request.Email,
             Email = request.Email,
             Firstname = firstname,
             Lastname = lastname,
-            Alias = request.Name,
-            RefreshToken = refreshToken,
-            RefreshTokenExpiryTime = DateTime.UtcNow.Add(jwtOptions.Value.RefreshTokenLifetime)
+            Alias = request.Name
         };
 
-        var result = await userManager.CreateAsync(
+        IdentityResult result = await userManager.CreateAsync(
             user,
             request.Password);
 
@@ -77,21 +70,10 @@ public class RegisterHandler(
             return;
         }
 
-        // Generate JWT token
-        var accessToken = JwtTokenHelper.GenerateJwtToken(
-            expiresIn: jwtOptions.Value.Lifetime,
-            issuer: jwtOptions.Value.Issuer,
-            audience: jwtOptions.Value.Audience,
-            key: jwtOptions.Value.Key,
-            userId: user.Id.ToString(),
-            email: user.Email ?? string.Empty,
-            alias: user.Alias,
-            firstname: user.Firstname ?? string.Empty,
-            lastname: user.Lastname ?? string.Empty,
-            portraitUrl: user.PortraitUrl);
+        await emailVerificationService.SendVerificationEmailAsync(user);
 
         await SendOkAsync(
-            new RegisterResponse(accessToken, user.RefreshToken),
-            cancellation: ct);
+            new RegisterResponse("Registration successful! Please check your email to verify your account."),
+            ct);
     }
 }